Doitsuyama

Sumo Reference Updates

Recommended Posts

4 hours ago, Doitsuyama said:

But I'm not sure if this would even be conceived as a positive change from the users of Sumo Reference

I know one forum user who would be very happy about it.... (Laughing...) (not me) 

While we have your attention, could I rather shamelessly check what the second column on the simple style torikumi list is for? 

http://www.sumoforum.net/forums/topic/12746-sumo-reference-updates/?do=findComment&comment=471100

Share this post


Link to post
Share on other sites
On 19/07/2022 at 00:25, Seiyashi said:

While we have your attention, could I rather shamelessly check what the second column on the simple style torikumi list is for? 

http://www.sumoforum.net/forums/topic/12746-sumo-reference-updates/?do=findComment&comment=471100

What second column? (Whistling...)

(It indeed used to be an order column over all bouts of the day, but it is bugged with the automated grabbing and I'm never using it anyway, so I removed it now)

  • Haha 2

Share this post


Link to post
Share on other sites

@Doitsuyama Is there any chance that the Japanese-language shikona could appear on the Rikishi / Kabu pages?  It's the one thing on the Japanese SR site that I find myself flipping into the Japanese version to look up not-infrequently.  

  • Like 1

Share this post


Link to post
Share on other sites
On 22/07/2022 at 14:17, Doitsuyama said:

It indeed used to be an order column over all bouts of the day, but it is bugged with the automated grabbing and I'm never using it anyway, so I removed it now

I'd just like you to know that I have to change my script that took the results off the database and compiled them into the form that I wanted to store them in, because it assumed that the format the results would be displayed in was static.  I don't think it's a huge problem to change it, but it had me scratching my head about what was wrong when it complained that there wasn't a hyperlink in the specified cell, and after digging through all the variables it was clear that the math to find the hyperlinked rikishi name was clearly off (getting the hyperlink is necessary to extract the rikishi ID, since I can't rely on names being unique).  Then I remembered the quoted change happening.  It's been so long since I wrote these scripts I hope I can figure out how they work and change them as appropriate. 

It just goes to show how the smallest change in anything computer related can totally throw off someone else's workflow that relied on things being very specifically formatted.  See https://xkcd.com/1172/

edit: Fixing only the hyperlink error ended up with entirely the wrong data being saved, so this is going to be a non-trivial problem.  Why would I ever write code with copious comments so that someone else would be able to understand it?  Future me cries.

Edited by Gurowake
  • Haha 2

Share this post


Link to post
Share on other sites

It wasn't too hard to fix once I started stepping through the routine in debug mode to see what it was doing.  But I never thought I would need to change anything.

Share this post


Link to post
Share on other sites
6 minutes ago, Seiyashi said:

Sounds like a column index error?

Yeah, I just had to find all the places where I was referencing columns, and change them appropriately.

Share this post


Link to post
Share on other sites
15 hours ago, Gurowake said:

It wasn't too hard to fix once I started stepping through the routine in debug mode to see what it was doing.  But I never thought I would need to change anything.

If you are not happy with my site, feel free to grab from the official NSK site. But be warned, you have absolutely no idea how often I had to change my code to adapt to changes on the NSK site.

  • Like 1
  • Haha 2

Share this post


Link to post
Share on other sites
7 hours ago, Doitsuyama said:

If you are not happy with my site, feel free to grab from the official NSK site. But be warned, you have absolutely no idea how often I had to change my code to adapt to changes on the NSK site.

I'm well aware that you're probably much more stable than the NSK, and I thank you for it.

Share this post


Link to post
Share on other sites
7 hours ago, Doitsuyama said:

If you are not happy with my site, feel free to grab from the official NSK site. But be warned, you have absolutely no idea how often I had to change my code to adapt to changes on the NSK site.

Just to be clear, I'm extremely grateful that you have a site with minimal frills for which this data is available.  My comments in this thread on this topic are mainly (1) being amused at how such a small change might throw someone's scripts off, and made me think of the XKCD comic linked and (2) me eternally having to weigh the advantages of fully commenting code vs. the time savings from not doing so since I assume I'll never need to change it.  I don't think I could possibly code in a production environment for that reason; I just absolutely hate commenting in code, preferring to get it right and leaving it.  I really shouldn't be doing that when I have to use outside sources, but I just can't get myself to take the time to do so.

  • Like 2

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now